fix(fm): remove synthesized finish tool call from stream path#9
Closed
subpop wants to merge 1 commit intoTom-Ryder:mainfrom
Closed
fix(fm): remove synthesized finish tool call from stream path#9subpop wants to merge 1 commit intoTom-Ryder:mainfrom
subpop wants to merge 1 commit intoTom-Ryder:mainfrom
Conversation
FoundationModelsClient.stream() was emitting a synthetic 'finish' tool call after streaming completed. This caused Chat to try executing it as a real tool, fail with 'Tool finish does not exist', and loop. The content is already streamed via .content() deltas so the synthetic finish is unnecessary. The generate() path retains it for the Agent class which expects it.
Owner
|
Thanks for opening this and tracking down the FM streaming issue. I ended up landing a broader fix on main because the stream-only change would also have affected Agent.stream(): cc2422f Really appreciate the PR and the investigation. |
Contributor
Author
Ah okay. I wasn't sure if it was a Chat-only bug. I did a little digging, but didn't dig deep enough it seems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FoundationModelsClient.stream() was emitting a synthetic 'finish' tool call after streaming completed. This caused Chat to try executing it as a real tool, fail with 'Tool finish does not exist', and loop. The content is already streamed via .content() deltas so the synthetic finish is unnecessary. The generate() path retains it for the Agent class which expects it.